Update Using-promises.mc#565
Merged
bschrammIBM merged 1 commit intoloopbackio:gh-pagesfrom Dec 13, 2017
Merged
Conversation
Adding promise examples
Contributor
|
Can one of the admins verify this patch? |
bajtos
approved these changes
Dec 12, 2017
Member
bajtos
left a comment
bajtos
left a comment
There was a problem hiding this comment.
Thank you for the pull request!
The changes look mostly good, I assume you have run the website to verify that include tip.html can handle code blocks.
@bschrammIBM could you please take a look too?
| // Resolving with a callback | ||
| next(); | ||
| }); | ||
| MyModel.observe('before save', function beforeSave(ctx, next) { |
Member
There was a problem hiding this comment.
Since next is not used by the function, I personally prefer to leave it from the function signature. That leaves even less temptation to incorrectly call it.
MyModel.observe('before save', function beforeSave(ctx) {
// Resolving with a promise
return Promise.resolve();
});
bschrammIBM
approved these changes
Dec 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding promise examples. Here is where this is coming from loopbackio/loopback-datasource-juggler#449 (comment). @bajtos could you review these changes please?