fix(cli): remove project references from examples#5204
Merged
Conversation
7 tasks
raymondfeng
reviewed
Apr 23, 2020
| // was checked out outside of our monorepo. | ||
| const tsconfigContent = await fs.readJson(tsconfig); | ||
| delete tsconfigContent.references; | ||
| delete tsconfigContent.compilerOptions.composite; |
Contributor
There was a problem hiding this comment.
Let’s set the composite flag to false as it may inherit its value from the base tsconfig.
emonddr
approved these changes
Apr 23, 2020
In #5155, we reworked our typescript setup to leverage composite mode and project references. This breaks our example applications when they are checked out standalone, typically via `lb4 example`. ```sh $ lb4 example todo (...) $ cd loopback4-example-todo $ npm t (...) > lb-tsc error TS6053: File '/private/packages/http-caching-proxy/tsconfig.json' not found. error TS6053: File '/private/packages/testlab/tsconfig.json' not found. (...) Found 10 errors. ``` This commit fixes the problem by introducing a new step to `lb4 example` command where we remove `references` field from `tsconfig.json` file and set the field `compilerOptions.composite` to `false`. Signed-off-by: Miroslav Bajtoš <mbajtoss@gmail.com>
raymondfeng
approved these changes
Apr 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #5155, we reworked our typescript setup to leverage composite mode and project references. This breaks our example applications when they are checked out standalone, typically via
lb4 example.This patch fixes the problem by introducing a new step to
lb4 examplecommand where we removereferencesandcompilerOptions.compositefield fromtsconfig.jsonfile.Implements #2609.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈