Merged
Conversation
|
I think the enum should follow the other values naming convention? |
Author
Thanks! Of course I made a mistake, will fix soon |
Author
Fixed |
FelixJacobi
approved these changes
Jul 5, 2025
gkralik
added a commit
to gkralik/bigbluebutton-api-php
that referenced
this pull request
Nov 17, 2025
"Update feature enum for BBB 3.0" (littleredbutton#225) introduced new cases for the Feature enum. The BBB feature 'userReactions' was mis-spelled and included as 'userActions' (case USER_ACTIONS). Add the correct USER_REACTIONS case with value 'userReactions'. Keep the wrong USER_ACTIONS case to not break existing (changing its value to userReactions is not possible as PHP enums do not allow duplicate values). See https://docs.bigbluebutton.org/development/api/#updates-to-api-in-bigbluebutton
This was referenced Nov 17, 2025
samuelwei
pushed a commit
that referenced
this pull request
Nov 17, 2025
"Update feature enum for BBB 3.0" (#225) introduced new cases for the Feature enum. The BBB feature 'userReactions' was mis-spelled and included as 'userActions' (case USER_ACTIONS). Add the correct USER_REACTIONS case with value 'userReactions'. Keep the wrong USER_ACTIONS case to not break existing (changing its value to userReactions is not possible as PHP enums do not allow duplicate values). See https://docs.bigbluebutton.org/development/api/#updates-to-api-in-bigbluebutton
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See docs https://docs.bigbluebutton.org/development/api/#updates-to-api-in-bigbluebutton
Also added privateChat, listed in https://docs.bigbluebutton.org/development/api/#get-post-create