Skip to content

Mintinstall.py - Replace dot button#465

Merged
clefebvre merged 6 commits intolinuxmint:masterfrom
Hilyxx:mintinstall.py
Jul 25, 2025
Merged

Mintinstall.py - Replace dot button#465
clefebvre merged 6 commits intolinuxmint:masterfrom
Hilyxx:mintinstall.py

Conversation

@Hilyxx
Copy link
Contributor

@Hilyxx Hilyxx commented Jun 1, 2025

This commit reworks the banner buttons:

  • Rework dots as visual indicators and add arrow buttons for slide navigation.
  • Add a transparent black frame to avoid visibility problems between banner colors and dots.

Before :
before

After :
final

@AxeldeWater
Copy link

Have you thought of combining the two? Like having arrows next to the dots on either side? Because getting rid of the dots completely is also impractical, it's nice to see how many slides there are.

@Hilyxx
Copy link
Contributor Author

Hilyxx commented Jun 4, 2025

@AxeldeWater

The dot buttons were initially placed below the banner. The developers decided to move them inside the banner, and I respect their choice.
However, this placement causes visibility problems with dark-colored banners. The buttons are rather unattractive (in my opinion) and slightly reduce accessibility. The buttons are small and can easily be missed when unintentionally clicking on the banner.

I don't want to complicate the code by adding dot buttons with the same function as the arrow buttons. I could add smaller dots that would serve as a visual indicator of the number of slides, but the legibility problem would remain.

I also need @mtwebster to agree with the original idea before I change anything.

@AxeldeWater
Copy link

I could add smaller dots that would serve as a visual indicator of the number of slides

I think that would be nice

@Hilyxx
Copy link
Contributor Author

Hilyxx commented Jun 5, 2025

@AxeldeWater

I added dots as a visual indicator and with a transparent black frame to avoid visibility problems with the banner colors.
Overall, I think the rendering looks pretty good. (PR isn't updated for now)

y

Or this one
Capture d’écran du 2025-06-05 21-24-52

@AxeldeWater
Copy link

What do you think of the second option, but in the middle? That would be the perfect solution in my opinion.

Hilyxx added 4 commits June 5, 2025 22:52
Rework banner buttons: 
- Add a visual indicator for the number of banners (dot)
- Merge arrow buttons and dots into a container
- Add a transparent black frame to avoid visibility problems with banner colors and dots.
Revert ' def start_slideshow_timer ' to the original code. 
useless addition.
Add space between banner summary and nav_box
@clefebvre
Copy link
Member

Very nice!

I'd prefer it on the right, like in second screenshot. We're close to release though and this is a very nice improvement already, so I'm merging it as it is for now. Well done.

@clefebvre clefebvre merged commit e3d27c9 into linuxmint:master Jul 25, 2025
@Hilyxx
Copy link
Contributor Author

Hilyxx commented Jul 25, 2025

Thank you @clefebvre

If you want, I can make a quick commit to restore the buttons on the right side of the banner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants