Merged
Conversation
Contributor
Author
|
@LaurenzV PTAL. The current implementation only targets |
LaurenzV
reviewed
Dec 17, 2025
yisibl
force-pushed
the
add-at-font-face
branch
from
1f1af7d to
afaeef9
Compare
yisibl
force-pushed
the
add-at-font-face
branch
from
afaeef9 to
fbf1e15
Compare
Contributor
Author
|
Thank you, I've added the new test |
|
Doc failure needs to be fixed and then it should be good to go. |
|
Actually, let me just fix it with a separate PR. |
|
Hmm, is it possible that you haven't rebased onto the newest main? I can't find the line. |
error[E0557]: feature has been removed --> src/lib.rs:42:29 | 42 | #![cfg_attr(docsrs, feature(doc_auto_cfg))] | ^^^^^^^^^^^^ feature has been removed | = note: removed in 1.92.0; see <rust-lang/rust#138907> for more information = note: merged into `doc_cfg` error: Compilation failed, aborting rustdoc
Contributor
Author
Fixed: |
|
Nevermind, I was the one looking at an old version. 😅 |
|
Thanks! |
LaurenzV
approved these changes
Dec 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the future, we may also add
@font-palette-valuesand@font-feature-values.Part of linebender/resvg#541