Add AbstractVssApi, get/put/list api handlers#10
Closed
G8XSU wants to merge 1 commit intolightningdevkit:mainfrom
Closed
Add AbstractVssApi, get/put/list api handlers#10G8XSU wants to merge 1 commit intolightningdevkit:mainfrom
G8XSU wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
This was referenced May 12, 2023
Closed
jkczyz
reviewed
May 17, 2023
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
Overall, this looks good. Is there any test code that you could add?
Contributor
Author
|
Added in #12 |
Contributor
No need to make separate PR for tests, IMO. |
Contributor
Author
|
Closing as it was reviewed as part of #12 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add AbstractVssApi, get/put/list api handlers