Cut 0.0.99 by TheBlueMatt · Pull Request #990 · lightningdevkit/rust-lightning

TheBlueMatt · 2021-07-08T19:32:19Z

This assumes #975 lands first.

codecov · 2021-07-08T19:48:34Z

Codecov Report

Merging #990 (c9a8b26) into main (e04a1b3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #990   +/-   ##
=======================================
  Coverage   90.76%   90.77%           
=======================================
  Files          60       60           
  Lines       30914    30914           
=======================================
+ Hits        28059    28061    +2     
+ Misses       2855     2853    -2

Impacted Files	Coverage Δ
lightning/src/ln/functional_tests.rs	`97.38% <0.00%> (+0.03%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e04a1b3...c9a8b26. Read the comment docs.

ariard · 2021-07-08T22:36:19Z

CHANGELOG.md

   `ChannelManager` will fail to deserialize both on version 0.0.98 and later
   versions. If you have such a `ChannelManager` available, a simple patch will
-   allow it to deserialize, please file an issue if you need assistance.
+   allow it to deserialize, please file an issue if you need assistance (#973).


Should you mention edbc30c which is bumping chan's serialization ?

Nope, its fully backwards- and forwards-compatible. 0.0.98 can read versions written by 0.0.99 (though it ignores the fee info) and 0.0.99 can read versions written by 0.0.98.

CHANGELOG.md

jkczyz · 2021-07-09T14:42:16Z

CHANGELOG.md

   `ChannelManager` will fail to deserialize both on version 0.0.98 and later
   versions. If you have such a `ChannelManager` available, a simple patch will
-   allow it to deserialize, please file an issue if you need assistance.
+   allow it to deserialize, please file an issue if you need assistance (#973).


It doesn't look like adding PR/issue numbers adds links

Hmm, is it necessary? Its kinda annoying to have a million links in a plaintext document, and its not hard to load the PR from the number.

Probably not necessary but I'd think it's less annoying since it is essentially write once, read many times.

jkczyz

Just some nits.

jkczyz · 2021-07-09T16:26:17Z

CHANGELOG.md

   `ChannelManager` will fail to deserialize both on version 0.0.98 and later
   versions. If you have such a `ChannelManager` available, a simple patch will
-   allow it to deserialize, please file an issue if you need assistance.
+   allow it to deserialize, please file an issue if you need assistance (#973).


Probably not necessary but I'd think it's less annoying since it is essentially write once, read many times.

CHANGELOG.md

valentinewallace

ACK mod jeff's nits

TheBlueMatt · 2021-07-09T16:35:15Z

Fixed nits and squashed. Will take after CI:

$ git diff-tree -U1 83110e35 c9a8b26d
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 0fa93a84..764e2ffd 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,2 +1,2 @@
-# 0.0.99 - WIP
+# 0.0.99 - 2021-07-09
 
@@ -25,5 +25,5 @@
    `ChannelManager` is loaded in 0.0.99 (#975).
- * We now reject HTLCs which are received to be forwarded out over private
-   channels unless `UserConfig::accept_forwards_to_priv_channels` is set. Note
-   that `UserConfig` is never serialized and must be provided via
+ * We now reject HTLCs which are received to be forwarded over private channels
+   unless `UserConfig::accept_forwards_to_priv_channels` is set. Note that
+   `UserConfig` is never serialized and must be provided via
    `ChannelManagerReadArgs::default_config` at each start (#975).
@@ -69,3 +69,3 @@
    versions. If you have such a `ChannelManager` available, a simple patch will
-   allow it to deserialize, please file an issue if you need assistance (#973).
+   allow it to deserialize. Please file an issue if you need assistance (#973).

TheBlueMatt added this to the 0.0.99 milestone Jul 8, 2021

ariard reviewed Jul 8, 2021

View reviewed changes

jkczyz reviewed Jul 9, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

TheBlueMatt force-pushed the 2021-07-0.0.99 branch 3 times, most recently from ea4862d to 11d4bb9 Compare July 9, 2021 14:03

jkczyz reviewed Jul 9, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

jkczyz reviewed Jul 9, 2021

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

jkczyz reviewed Jul 9, 2021

View reviewed changes

TheBlueMatt force-pushed the 2021-07-0.0.99 branch 2 times, most recently from 5fea2ad to 83110e3 Compare July 9, 2021 16:28

jkczyz approved these changes Jul 9, 2021

View reviewed changes

valentinewallace approved these changes Jul 9, 2021

View reviewed changes

TheBlueMatt added 2 commits July 9, 2021 16:34

Add documentation for all PRs slated to land for 0.0.99

230c72b

Bump most crate versions to 0.0.99 and lightning-invoice to 0.7.0

c9a8b26

TheBlueMatt force-pushed the 2021-07-0.0.99 branch from 83110e3 to c9a8b26 Compare July 9, 2021 16:34

TheBlueMatt merged commit afae12e into lightningdevkit:main Jul 9, 2021

Conversation

TheBlueMatt commented Jul 8, 2021

Uh oh!

codecov bot commented Jul 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ariard Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt Jul 8, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jkczyz Jul 9, 2021

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt Jul 9, 2021

Choose a reason for hiding this comment

Uh oh!

jkczyz Jul 9, 2021

Choose a reason for hiding this comment

Uh oh!

jkczyz left a comment

Choose a reason for hiding this comment

Uh oh!

jkczyz Jul 9, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

valentinewallace left a comment

Choose a reason for hiding this comment

Uh oh!

TheBlueMatt commented Jul 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jul 8, 2021 •

edited

Loading