Bump MSRV to 1.30.0#671
Merged
TheBlueMatt merged 1 commit intolightningdevkit:masterfrom Aug 19, 2020
Merged
Conversation
We wanted to bump to 1.29 to continue to support mrustc bootstrapping, but on 1.29 there's a bug preventing us from compiling the lightning package only, thus parts of lightning-net-tokio cause a compilation error. The advantage of bumping the MSRV is an improved borrow checker which should enable improved code quality, and not having jump through weird hoops sometimes to get 1.22 working.
Contributor
|
Is this bug documented anywhere? if not how can I reproduce it locally? |
Contributor
Author
I can't find it documented, but to repro just run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We wanted to bump to 1.29 to continue to support mrustc bootstrapping, but on 1.29
there's a bug preventing us from compiling the lightning package only, thus parts
of lightning-net-tokio cause a compilation error.
The advantage of bumping the MSRV is an improved borrow checker which should
enable improved code quality, and not having jump through weird hoops sometimes
to get 1.22 working.
Maybe this is a good compromise in the meantime, and we can always bump more later?
It'd make part of #667 a bit nicer (though admittedly it's possible there's a workaround to my current hack for 1.22, and I'm just too tired of 1.22 to find it lol). I'm OK to revisit bumping MSRV later if it's preferred though.
Related to #471