Trivial #3016 followups#3643
Merged
TheBlueMatt merged 3 commits intolightningdevkit:mainfrom Mar 4, 2025
Merged
Conversation
e41e756 removed `ChannelManager::send_payment_with_route` due to a rebase error as it was originally written when `send_payment_with_route` had been made test-only. Here we restore it to be public.
e41e756 introduced some indentation errors that we fix here.
e41e756 started exposing some tests but left some functions as non-pub that were now pub (though it doesn't actually matter as we expose the function pointers directly via `inventory).
|
👋 Thanks for assigning @wpaulino as a reviewer! |
wpaulino
approved these changes
Mar 4, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Closed
Member
|
thank you for the fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.