Make channel_type optional in ChannelOpenRequest event.#2805
Closed
domZippilli wants to merge 1 commit intolightningdevkit:mainfrom
Closed
Make channel_type optional in ChannelOpenRequest event.#2805domZippilli wants to merge 1 commit intolightningdevkit:mainfrom
domZippilli wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
Peers may send messages requesting to open a channel without specifying the channel type. This gets inferred by LDK when the channel actually opens, but can be passed to the event handler as an Option so the node may factor the lack of specificity in to the channel opening decision. This should fix lightningdevkit#2804.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2805 +/- ##
==========================================
- Coverage 88.78% 88.43% -0.35%
==========================================
Files 112 114 +2
Lines 88474 91814 +3340
Branches 88474 91814 +3340
==========================================
+ Hits 78553 81199 +2646
- Misses 7686 8123 +437
- Partials 2235 2492 +257 ☔ View full report in Codecov by Sentry. |
Collaborator
|
Supersceded by #2808. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Peers may send messages requesting to open a channel without specifying the channel type. This gets inferred by LDK when the channel actually opens, but can be passed to the event handler as an Option so the node may factor the lack of specificity in to the channel opening decision.
This should fix #2804.
ACK in advance that I need to rebase to main. (is there interest in hotfixing this for 118/119?)