Skip to content

[WIP] New ChannelId struct#2484

Closed
optout21 wants to merge 8 commits intolightningdevkit:mainfrom
optout21:channel-id-4struct0
Closed

[WIP] New ChannelId struct#2484
optout21 wants to merge 8 commits intolightningdevkit:mainfrom
optout21:channel-id-4struct0

Conversation

@optout21
Copy link
Contributor

@optout21 optout21 commented Aug 9, 2023

Fixes #2408 . Introduces a new ChannelId struct, enclosing the 32-byte data, and specific constructors, for normal funding-tx-based and for temporary channel IDs.

TODO:

  • Determine how it affects APIs, uses, backward-compatibility
  • Tests for ChannelId serialization/deserialization
  • New macro log_channel_id!()
  • Review hints

@optout21
Copy link
Contributor Author

optout21 commented Aug 9, 2023

Redone in #2485, with squashed commits, closing.

@optout21 optout21 closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abstraction of ChannelId type

1 participant