Flip keysend feature bit on#2465
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Jul 31, 2023
Merged
Conversation
TheBlueMatt
approved these changes
Jul 31, 2023
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2465 +/- ##
=======================================
Coverage 90.33% 90.34%
=======================================
Files 106 106
Lines 55732 55734 +2
Branches 55732 55734 +2
=======================================
+ Hits 50347 50351 +4
+ Misses 5385 5383 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wpaulino
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keysend seems to be the only feature bit that's in the node context and not the init context, so whenever we switched to providing the default init feature bits as our node feature bits, we must've left out keysend!