Struct-ify reconnect_nodes test util args#2459
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Jul 31, 2023
Merged
Conversation
Makes it easier to add new arguments without a ton of resulting test changes. Useful for route blinding testing because we need to check for malformed HTLCs, which is not currently supported by reconnect_nodes. It also makes it easier to tell what is being checked in relevant tests.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2459 +/- ##
==========================================
+ Coverage 90.32% 90.34% +0.01%
==========================================
Files 106 106
Lines 55732 55781 +49
Branches 55732 55781 +49
==========================================
+ Hits 50342 50397 +55
+ Misses 5390 5384 -6
☔ View full report in Codecov by Sentry. |
wpaulino
approved these changes
Jul 28, 2023
tnull
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes it easier to add new arguments without a ton of resulting test changes. Useful for route blinding testing because we need to check for malformed HTLCs, which is not currently supported by
reconnect_nodes. It also makes it easier to tell what is being checked in relevant tests.