Merged
Conversation
The `RefCell` was necessary in a previous iteration of the code in which the iterator was not `Clone` so we needed interior mutability in order to consume the iterator. Now that it is `Clone`, we can drop it, as we're no longer mutating the original iterator.
tnull
previously approved these changes
Jul 17, 2023
Contributor
|
CI breakage should be #2424 |
dunxen
previously approved these changes
Jul 17, 2023
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 90.27% 90.28%
=======================================
Files 106 106
Lines 55657 55664 +7
Branches 55657 55664 +7
=======================================
+ Hits 50247 50258 +11
+ Misses 5410 5406 -4
☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Jul 18, 2023
TheBlueMatt
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.