Split up KeysInterface parameters into its comprising traits.#1952
Closed
arik-so wants to merge 6 commits intolightningdevkit:mainfrom
Closed
Split up KeysInterface parameters into its comprising traits.#1952arik-so wants to merge 6 commits intolightningdevkit:mainfrom
KeysInterface parameters into its comprising traits.#1952arik-so wants to merge 6 commits intolightningdevkit:mainfrom
Conversation
… `ChannelMonitor` and `OnchainTxHandler` types.
…`blinded_path.rs` and `inbound_payment.rs`.
…ng traits where a singular substitution is possible.
… `Channel` and `ChannelManager` types.
arik-so
force-pushed
the
2023-01-keys-interface-removal-chunked
branch
from
c8f6bd2 to
5b6f16a
Compare
Codecov ReportBase: 90.73% // Head: 90.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1952 +/- ##
========================================
Coverage 90.73% 90.74%
========================================
Files 97 97
Lines 50539 51035 +496
Branches 50539 51035 +496
========================================
+ Hits 45859 46311 +452
- Misses 4680 4724 +44
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
|
Landed the version in #1930 because it already had an ack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.