Add missing counterparty_node_id in force_close_channel calls#1485
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom May 16, 2022
Merged
Conversation
TheBlueMatt
approved these changes
May 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #1485 +/- ##
==========================================
- Coverage 90.89% 90.87% -0.02%
==========================================
Files 76 76
Lines 42068 42075 +7
Branches 42068 42075 +7
==========================================
- Hits 38238 38237 -1
- Misses 3830 3838 +8
Continue to review full report at Codecov.
|
arik-so
approved these changes
May 16, 2022
jkczyz
approved these changes
May 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
counterparty_node_idis required to be passed toforce_close_channelafter #1479 was merged. This adds the param to theforce_close_channelcalls that were added with #1429.