Skip to content

Add missing counterparty_node_id in force_close_channel calls#1485

Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
ViktorT-11:2022-05-add-force-close-param
May 16, 2022
Merged

Add missing counterparty_node_id in force_close_channel calls#1485
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
ViktorT-11:2022-05-add-force-close-param

Conversation

@ViktorT-11
Copy link
Contributor

@ViktorT-11 ViktorT-11 commented May 16, 2022

The counterparty_node_id is required to be passed to force_close_channel after #1479 was merged. This adds the param to the force_close_channel calls that were added with #1429.

@ViktorT-11 ViktorT-11 marked this pull request as ready for review May 16, 2022 20:31
@codecov-commenter
Copy link

Codecov Report

Merging #1485 (d543ac0) into main (257a6f3) will decrease coverage by 0.01%.
The diff coverage is 98.16%.

@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
- Coverage   90.89%   90.87%   -0.02%     
==========================================
  Files          76       76              
  Lines       42068    42075       +7     
  Branches    42068    42075       +7     
==========================================
- Hits        38238    38237       -1     
- Misses       3830     3838       +8     
Impacted Files Coverage Δ
lightning/src/ln/channelmanager.rs 84.66% <92.59%> (-0.02%) ⬇️
lightning-background-processor/src/lib.rs 94.37% <100.00%> (ø)
lightning-persister/src/lib.rs 93.45% <100.00%> (ø)
lightning/src/ln/chanmon_update_fail_tests.rs 97.76% <100.00%> (ø)
lightning/src/ln/functional_test_utils.rs 95.54% <100.00%> (+<0.01%) ⬆️
lightning/src/ln/functional_tests.rs 97.08% <100.00%> (-0.10%) ⬇️
lightning/src/ln/monitor_tests.rs 100.00% <100.00%> (ø)
lightning/src/ln/payment_tests.rs 99.23% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs 97.95% <100.00%> (ø)
lightning/src/ln/shutdown_tests.rs 96.50% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5629e5...d543ac0. Read the comment docs.

@TheBlueMatt TheBlueMatt merged commit 342698f into lightningdevkit:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants