Skip to content

Rewrite InvoicePayer retry to correctly handle MPP partial failures #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheBlueMatt merged 8 commits into from
Oct 31, 2021
Merged

Rewrite InvoicePayer retry to correctly handle MPP partial failures #1141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
16f7428
Move PaymentId to a [u8; 32] in bindings as for other hash objects
TheBlueMatt Oct 26, 2021
d73e434
Provide payment retry data when an MPP payment failed partially
TheBlueMatt Oct 26, 2021
51dd344
Expand `InvoicePayer` documentation somewhat to clarify edge-cases
TheBlueMatt Oct 30, 2021
e9e8a7d
Dont unwrap `RouteParameter::expiry_time` as users can set it
TheBlueMatt Oct 27, 2021
7112661
Rewrite InvoicePayer retry to correctly handle MPP partial failures
TheBlueMatt Oct 26, 2021
2b8c287
Add an integration test for InvoicePayer paying when one part fails
TheBlueMatt Oct 27, 2021
9c5dccd
Add integration test for InvoicePayerretry on an immediate failure
TheBlueMatt Oct 27, 2021
199d258
Check for invoice expiry in InvoicePayer before we send any HTLCs
TheBlueMatt Oct 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions fuzz/src/chanmon_consistency.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,8 @@ fn check_payment_err(send_err: PaymentSendFailure) {
PaymentSendFailure::AllFailedRetrySafe(per_path_results) => {
for api_err in per_path_results { check_api_err(api_err); }
},
PaymentSendFailure::PartialFailure(per_path_results) => {
for res in per_path_results { if let Err(api_err) = res { check_api_err(api_err); } }
PaymentSendFailure::PartialFailure { results, .. } => {
for res in results { if let Err(api_err) = res { check_api_err(api_err); } }
},
}
}
Expand Down
Loading