Conversation
Codecov Report
@@ Coverage Diff @@
## main #1044 +/- ##
==========================================
- Coverage 90.84% 90.82% -0.02%
==========================================
Files 65 65
Lines 32795 32795
==========================================
- Hits 29792 29786 -6
- Misses 3003 3009 +6
Continue to review full report at Codecov.
|
valentinewallace
left a comment
valentinewallace
left a comment
There was a problem hiding this comment.
ACK mod comments
CHANGELOG.md
Outdated
| * If | ||
| `lightning::chain::keysinterface::KeysInterface::get_shutdown_scriptpubkey` | ||
| returns a `ShutdownScript` which was constructed using a constructor other | ||
| than `ShutdownScript::new_p2wpkh_from_pubkey`, the `ChannelManager` will not | ||
| be readable by versions prior to 0.0.100. Further, versions prior to 0.0.100 |
There was a problem hiding this comment.
That method is pub(crate) so you'll never see a ShutdownScript constructed that way in user code. So any new channels created will not be readable. However, any channel whose shutdown script was created using the old get_shutdown_pubkey API will continue to be readable.
There was a problem hiding this comment.
Hmm, should we make that method pub?
There was a problem hiding this comment.
Not sure. Actually, KeysManager is currently usingnew_p2wpkh_from_pubkey, so anyone using it for their KeysInterface shouldn't run into this problem.
|
Tweaked changelog wordings to address feedback. |
|
Squashed without changes: |
3 participants
Dependent on #1011, this cuts 0.0.100