Rename to LdkServer. #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Rebased on main |
arik-so
approved these changes
Nov 23, 2024
tnull
reviewed
Nov 23, 2024
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Seems the package names for cli, client, and protos will also need to be renamed before we're able to publish them. What is the current thinking on the naming scheme here?
Contributor
Author
Yes, I was thinking of renaming them to ldk-server-* i.e., ldk-server-cli, ldk-server-client, ldk-server-protos/ldk-server-types, ldk-server. I am going to merge this one, since i need to base my PRs off of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.