Allow for trusted inbound 0conf channels#69
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Jun 13, 2023
Merged
Conversation
danielnordh
added a commit
to bdgwallet/dailywallet
that referenced
this pull request
Apr 24, 2023
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
from
87a3583 to
9610723
Compare
Collaborator
Author
|
Rebased. |
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
from
9610723 to
e0bb02c
Compare
Collaborator
Author
|
Fixed some things and added a rudimentary test to check 0conf actually works. Also rebased on #25 while at it. |
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
from
e0bb02c to
2b3959e
Compare
Collaborator
Author
|
Rebased after #25 has been merged. |
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
4 times, most recently
from
4d90ae4 to
7de34ce
Compare
Collaborator
Author
Undrafting as both concerns are fixed: trusted peers are now set via |
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
from
7de34ce to
095e82b
Compare
Collaborator
Author
|
Rebased on main. |
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
4 times, most recently
from
b4fba51 to
bb6f5c2
Compare
Collaborator
Author
|
Rebased on main. |
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
3 times, most recently
from
0a8a0ff to
72b155c
Compare
Collaborator
Author
|
Rebased on main. |
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
from
72b155c to
2b35f53
Compare
Collaborator
Author
|
Rebased on main. |
jkczyz
reviewed
Jun 12, 2023
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
from
2b35f53 to
db6ede7
Compare
jkczyz
reviewed
Jun 13, 2023
Contributor
jkczyz
left a comment
jkczyz
left a comment
There was a problem hiding this comment.
LGTM. Feel free to squash fixups.
tnull
force-pushed
the
2023-04-allow-manual-0conf
branch
from
db6ede7 to
4c26c25
Compare
Collaborator
Author
Squashed without further changes. |
jkczyz
approved these changes
Jun 13, 2023
danielnordh
added a commit
to bdgwallet/dailywallet
that referenced
this pull request
Jul 13, 2023
* Include LDK Node package, skeleton manager class * WIP * make Node published, move build to start() * Create node in new flow, listen for node to switch to home * Sync when homescreen opens * Remove unused blocksocket * Sync on dispatchQueue * TEMP: save node seed in keychain and check on start * Use ldknode for onchain address * Use ldknode for total and spendable onchain balance * Remove bdkmanager, ldkmanager * Remove bdk-swift package * Move extractNodeSeed to backupmanager * Tweak temp spacing * Refactor * Refactor * Refactor listeningAddress to one default * Replace default url * Use local branch of ldk-node to allow 0conf channels lightningdevkit/ldk-node#69 * Test Voltage wrapped invoice creation, new file LSP.swift * Print node id and original invoice for debugging * Replace request QR code with UnifiedQRCode * Use amount in lightning invoice (not yet for onchain as it needs conversion) * Include onchain amount in unified request, extensions for converting from sats to bitcoin * Replace with official LDKNode package * Use static file directory path, previous caused errors * Reduce invoice expiry time to less than 10 minutes set by Voltage * Refactor BackupManager, use mnemonic with ldkNode (not working) * Revert to filemanager path * Update readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #25.We set the peer to manually handle incoming channel request and allow inbound 0conf channels for trusted peers.
Setting this to draft as a) I'm not sure we'd always want to go the manually accept route and b) we want to always expose this as an additional bool on connect methods and c) this needs additional tests.