Refresh the AP pool after stopping the receiver#464
Merged
devgianlu merged 4 commits intolibrespot-org:devfrom Feb 8, 2022
Merged
Refresh the AP pool after stopping the receiver#464devgianlu merged 4 commits intolibrespot-org:devfrom
devgianlu merged 4 commits intolibrespot-org:devfrom
Conversation
Before, we tried to refresh the AP pool before stopping the receiver. If the AP pool refresh failed it would throw an exception and the receiver would not be stopped, making it trying to access a null pointer afterwards. This should fix librespot-org#447.
Member
|
LGTM, nice catch! |
devgianlu
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, we tried to refresh the AP pool before stopping the receiver. If the AP pool refresh failed it would throw an exception and the receiver would not be stopped, making it trying to access a null pointer afterwards. This should fix #447.
This PR also includes some other minor changes related to yesterday's PR (#460) which I overlooked.