feat: Add GET /instance endpoint, which returns some basic information about the current session#403
Merged
devgianlu merged 3 commits intolibrespot-org:devfrom Sep 16, 2021
Twinki14:dev-feat-instance-get
Merged
feat: Add GET /instance endpoint, which returns some basic information about the current session#403devgianlu merged 3 commits intolibrespot-org:devfrom Twinki14:dev-feat-instance-get
devgianlu merged 3 commits intolibrespot-org:devfrom
Twinki14:dev-feat-instance-get
Conversation
…n about the current session - `device_id`, `device_name`,`device_type`, `country_code`, and `preferred_locale`
devgianlu
requested changes
Sep 16, 2021
api/src/main/java/xyz/gianlu/librespot/api/handlers/InstanceHandler.java
Show resolved
Hide resolved
api/src/main/java/xyz/gianlu/librespot/api/handlers/InstanceHandler.java
Show resolved
Hide resolved
- 'Please extract this to a variable instead of calling forSession twice.'
- Switch to 405 / method not allowed in InstanceHandler
devgianlu
approved these changes
Sep 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web-apifor basic information about the session includingdevice_id,device_name, anddevice_typedevice_id,device_name,device_type,country_code, andpreferred_localeExample request:
{ "device_id": "22ed0b3e74ad2001d16b7ea751fc58bb7a1ae686", "device_name": "librespot-java", "device_type": "COMPUTER", "country_code": "US", "preferred_locale": "en" }