Use SLF4J API's in player module instead of Log4J #338
Merged
devgianlu merged 4 commits intolibrespot-org:devfrom Apr 13, 2021
mitschwimmer:dev
Merged
Use SLF4J API's in player module instead of Log4J #338devgianlu merged 4 commits intolibrespot-org:devfrom mitschwimmer:dev
devgianlu merged 4 commits intolibrespot-org:devfrom
mitschwimmer:dev
Conversation
Contributor
Author
|
Hm, the build step "import of GPG secrets" fails. I assume this is a permission thing? |
Member
Yep, now fixed.
That particular call is expensive, just added a check on the log level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I just asked for the lib-module to utilize SLF4J. But as the player module is now intended to be used on Android it should use Android-friendly logging as well.
The way it is done should allow to keep LOG4J as default. In case the runtime is Android one will need to force exclude LOG4J from the dependencies in gradle and add a SLF4J compatible wrapper for the Android Logging System.
Remarks