Skip to content

fix: can't sign in by cookie on leetcode-cn site#55

Merged
jdneo merged 2 commits intoleetcode-tools:masterfrom
dzz007:master
Mar 31, 2021
Merged

fix: can't sign in by cookie on leetcode-cn site#55
jdneo merged 2 commits intoleetcode-tools:masterfrom
dzz007:master

Conversation

@dzz007
Copy link

@dzz007 dzz007 commented Mar 21, 2021

This commit fixes the problem where leetcode-cn sign-in by cookie fails.
It seems like leetcode-cn is now using the same sign-in cookie mechanism as the US site.

@dzz007
Copy link
Author

dzz007 commented Mar 22, 2021

@jdneo Hi, can you help me to review this pull request please to fix the cookie sign in issue please? I will also create another pull request later on to add an option to disable translation on the CN end point.

@jdneo
Copy link

jdneo commented Mar 29, 2021

@yihong0618 would you mind to take a look? 😄

@yihong0618
Copy link

@jdneo @dzz007 OK~

@yihong0618
Copy link

LGTM

@jdneo jdneo merged commit dd8ba8b into leetcode-tools:master Mar 31, 2021
@jdneo
Copy link

jdneo commented Mar 31, 2021

Thank you @yihong0618 @dzz007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments