add file.codeData to extract user code#23
Merged
jdneo merged 3 commits intoleetcode-tools:masterfrom Sep 17, 2019
magic-akari:feat/extract-user-code
Merged
add file.codeData to extract user code#23jdneo merged 3 commits intoleetcode-tools:masterfrom magic-akari:feat/extract-user-code
jdneo merged 3 commits intoleetcode-tools:masterfrom
magic-akari:feat/extract-user-code
Conversation
jdneo
reviewed
Sep 16, 2019
| ${comment.line} | ||
| {{ desc.forEach(function(x) { }}${comment.line} ${x} | ||
| {{ }) }}${comment.end} | ||
| ${comment.singleLine} @lc code=start |
There was a problem hiding this comment.
I'm thinking that adding a single empty line between the block comments and the single line comments. Because in some of the languages the comments styles are different.
Besides they belongs to different section.
What do you think?
Author
There was a problem hiding this comment.
Yes, adding a single empty line is better.
lib/file.js
Outdated
There was a problem hiding this comment.
this.isWindows() ? '\r\n' : '\n'
Use os.EOL instead.
jdneo
approved these changes
Sep 17, 2019
|
Thanks @magic-akari ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LeetCode-OpenSource/vscode-leetcode#418