Replace UIScreen.main to get display scale on iOS 13.0 and later#275
Merged
lucdion merged 4 commits intolayoutBox:masterfrom Nov 3, 2023
Merged
Replace UIScreen.main to get display scale on iOS 13.0 and later#275lucdion merged 4 commits intolayoutBox:masterfrom
UIScreen.main to get display scale on iOS 13.0 and later#275lucdion merged 4 commits intolayoutBox:masterfrom
Conversation
hyun99999
changed the title
UIApplication instead of UIScreen.main on iOS 13.0 and later
lucdion
approved these changes
Oct 19, 2023
Contributor
Author
|
Thank you for your approved review! |
Member
|
@hyun99999 , could you adjust the results of the 2 tests that fails, then I will merge your PR. Thanks |
hyun99999
changed the title
UIApplication instead of UIScreen.main on iOS 13.0 and laterUIScreen.main to get display scale on iOS 13.0 and later
Contributor
Author
|
@lucdion I find another way to get screen's scale. |
Member
|
Thanks for the PR. A new release is available with your change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UIScree.mainwill be deprecated in a future version of iOS.I used
UIAplicationto get display's scale.developer doc > mian already deprecated. It causes serious errors in the near future.
So have to change another way. And
UIApplicationis the one way of getting display's scale. That is available fromiOS 13.0. This is why control flow hasiOS 13.0condition.