chore: commonizes several FDv2 related types in Common#140
Merged
tanderson-ld merged 3 commits intomainfrom Feb 26, 2026
Merged
chore: commonizes several FDv2 related types in Common#140tanderson-ld merged 3 commits intomainfrom
tanderson-ld merged 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
tanderson-ld
commented
Feb 26, 2026
Contributor
Author
There was a problem hiding this comment.
For reviewers: Renamed this from FDv2SourceResult.State to SourceSignal to reduce similarity to a very similar DataSourceStatusProvider enum that already exists that talks about data source state.
/**
* An enumeration of possible values for {@link DataSourceStatusProvider.Status#getState()}.
*/
public enum State {
kinyoklion
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves several types from java server to java common for re-use in Android SDK. ChangeSet has been made generic on the type of the data. There should be no behavioral changes due to this PR.
Note
Low Risk
Low risk: this PR only adds new shared types/enums (no runtime logic changes) but may require downstream modules to update imports/types when adopting the new
ChangeSet<T>API.Overview
Commonizes FDv2 model types in
lib/shared/common. Adds a newcom.launchdarkly.sdk.fdv2package with shared public types for FDv2 data sources.Introduces a generic
ChangeSet<T>(withChangeSetType,Selector, and persistence/environment metadata) plus enumsSourceResultTypeandSourceSignal, and documents intended usage viapackage-info.java.Written by Cursor Bugbot for commit 14c6425. This will update automatically on new commits. Configure here.
BEGIN_COMMIT_OVERRIDE
feat: commonizes several FDv2 related types
END_COMMIT_OVERRIDE