Skip to content

chore: commonizes several FDv2 related types in Common#140

Merged
tanderson-ld merged 3 commits intomainfrom
ta/SDK-1817/commonizing-fdv2-source-types-common
Feb 26, 2026
Merged

chore: commonizes several FDv2 related types in Common#140
tanderson-ld merged 3 commits intomainfrom
ta/SDK-1817/commonizing-fdv2-source-types-common

Conversation

@tanderson-ld
Copy link
Contributor

@tanderson-ld tanderson-ld commented Feb 26, 2026

This PR moves several types from java server to java common for re-use in Android SDK. ChangeSet has been made generic on the type of the data. There should be no behavioral changes due to this PR.


Note

Low Risk
Low risk: this PR only adds new shared types/enums (no runtime logic changes) but may require downstream modules to update imports/types when adopting the new ChangeSet<T> API.

Overview
Commonizes FDv2 model types in lib/shared/common. Adds a new com.launchdarkly.sdk.fdv2 package with shared public types for FDv2 data sources.

Introduces a generic ChangeSet<T> (with ChangeSetType, Selector, and persistence/environment metadata) plus enums SourceResultType and SourceSignal, and documents intended usage via package-info.java.

Written by Cursor Bugbot for commit 14c6425. This will update automatically on new commits. Configure here.

BEGIN_COMMIT_OVERRIDE
feat: commonizes several FDv2 related types
END_COMMIT_OVERRIDE

@tanderson-ld tanderson-ld requested a review from a team as a code owner February 26, 2026 20:26
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Copy link
Contributor Author

@tanderson-ld tanderson-ld Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Renamed this from FDv2SourceResult.State to SourceSignal to reduce similarity to a very similar DataSourceStatusProvider enum that already exists that talks about data source state.

  /**
   * An enumeration of possible values for {@link DataSourceStatusProvider.Status#getState()}.
   */
  public enum State {

@tanderson-ld tanderson-ld changed the title chore: commonizes several FDv2 related types Common chore: commonizes several FDv2 related types Feb 26, 2026
@tanderson-ld tanderson-ld changed the title Common chore: commonizes several FDv2 related types chore: commonizes several FDv2 related types in Common Feb 26, 2026
@tanderson-ld tanderson-ld merged commit ef1e204 into main Feb 26, 2026
21 checks passed
@tanderson-ld tanderson-ld deleted the ta/SDK-1817/commonizing-fdv2-source-types-common branch February 26, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants