ci: Add job to check that sqlx builds with its declared minimum dependencies#3340
Merged
abonander merged 2 commits intolaunchbadge:mainfrom Jul 11, 2024
Merged
Conversation
iamjpotts
force-pushed
the
20240710-check-minimal-versions
branch
from
5083db0 to
d6510d3
Compare
…dencies Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
…n declared minimum versions Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
iamjpotts
force-pushed
the
20240710-check-minimal-versions
branch
from
d6510d3 to
df27b1a
Compare
Contributor
Author
|
Clarification: The final (merged) version of this PR did not attempt to compile tests, as that would have required generating a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents future occurrences of situations similar to #3118, where a change was made to
sqlxto resolve a deprecation warning, the change is not supported by the dependency version declared inCargo.toml, and the lock file has a newer version than what is declaredCargo.toml.New CI job forces a downgrade of all dependencies to their minimum versions (ignoring the committed lock file), and attempts to compile the crate and its tests.
In
Cargo.toml, thechronoandlogcrates were both upgraded to the oldest version that allowed thesqlxcrate to build. This did not impact the lock file, which has newer versions of both.