spdm: large-transfer: set chunk capability#6
Open
twilfredo wants to merge 47 commits intol1k:spdm-futurefrom
Open
spdm: large-transfer: set chunk capability#6twilfredo wants to merge 47 commits intol1k:spdm-futurefrom
twilfredo wants to merge 47 commits intol1k:spdm-futurefrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the flags field of a GET_CAPABILITIES request, ensure we indicate that large transfers are supported by setting the CHUNK_CAP bit [1].
[1] SPDM Spec 1.3: Table 13
libspdmpicked this up during testing here: https://github.com/DMTF/libspdm/blob/704d5652b2eeb451fffbd1bb1129046e377c9cf3/library/spdm_responder_lib/libspdm_rsp_capabilities.c#L221