Skip to content

Update Examples to stop using deprecated versions#1155

Merged
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
moshevayner:fix-issue-967
May 12, 2020
Merged

Update Examples to stop using deprecated versions#1155
k8s-ci-robot merged 2 commits intokubernetes-client:masterfrom
moshevayner:fix-issue-967

Conversation

@moshevayner
Copy link
Member

@moshevayner moshevayner commented Apr 29, 2020

Fixes #967

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 29, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Apr 29, 2020

Welcome @MoShitrit!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from roycaihw and yliaog April 29, 2020 23:07
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 29, 2020
@moshevayner
Copy link
Member Author

moshevayner commented Apr 30, 2020

/assign @yliaog

@codecov-io
Copy link

codecov-io commented Apr 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@10a7f95). Click here to learn what that means.
The diff coverage is n/a.

@moshevayner moshevayner mentioned this pull request Apr 30, 2020
Closed
@palnabarun
Copy link
Member

palnabarun commented May 1, 2020

/assign

@moshevayner
Copy link
Member Author

moshevayner commented May 10, 2020

Hey @roycaihw!
I was wondering if you had a chance to take a look at the travisCI webhook issue yet?
I'd love to get this merged if everything looks good 😄
Thanks!

@moshevayner moshevayner mentioned this pull request May 11, 2020
Closed
6 tasks
roycaihw
roycaihw reviewed May 11, 2020
View reviewed changes
examples/notebooks/create_deployment.ipynb
"metadata": {
"deletable": true,
"editable": true
},
Copy link
Member

@roycaihw roycaihw May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes auto-generated? If so, could you split the generated change into a separate commit? That will make it easier to review

Copy link
Member Author

@moshevayner moshevayner May 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually edited these files in an IDE that has an integration with Jupyter notebook integration (IntelliJ IDEA, fwiw) so it gives a pretty convenient way to edit the file in a convenient way.
Nothing was auto-generated here.
I guess it might've added some additional fields which it wasn't supposed to.
Let me see if I can reduce the amount of changes here.

Copy link
Member Author

@moshevayner moshevayner May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roycaihw OK I was able to clean up the mess that was made there, it's looking better now.
To sum up: I updated the versions to use the current ones, and removed the examples that are no longer relevant (Create DeploymentRollback object). There was also an empty cell at the bottom that didn't seem to have any purpose, so I took the liberty of removing that as well.
Please let me know if any further changes are needed.
Thanks!

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 11, 2020
@palnabarun
Copy link
Member

palnabarun commented May 12, 2020

Thanks @MoShitrit for updating the examples.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 12, 2020
@roycaihw
Copy link
Member

roycaihw commented May 12, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 12, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MoShitrit, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@k8s-ci-robot k8s-ci-robot merged commit cef5e9b into kubernetes-client:master May 12, 2020
@moshevayner moshevayner deleted the fix-issue-967 branch May 12, 2020 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roycaihw roycaihw roycaihw left review comments

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@roycaihw roycaihw

@palnabarun palnabarun

@yliaog yliaog

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Examples use deprecated API since k8s v1.16

6 participants

@moshevayner @k8s-ci-robot @codecov-io @palnabarun @roycaihw @yliaog