Switch --permission to accept >=1 parameters#966
Merged
inclement merged 1 commit intokivy:masterfrom Jan 12, 2017
Merged
Conversation
When used with a single value -> ['param'], two or more values -> ['param1', 'param2'], two or more --permission args -> [['param1', 'param2'], ['param3', 'param4']] which is later flattened. Closes kivy#673
inclement
reviewed
Dec 23, 2016
| args.permissions = [] | ||
| elif args.permissions: | ||
| if isinstance(args.permissions[0], list): | ||
| args.permissions = [p for perm in args.permissions for p in perm] |
Member
There was a problem hiding this comment.
Using p as the variable name twice makes me twitchy ;)
Contributor
Author
There was a problem hiding this comment.
I think I don't understand. It's a list comprehension, it wants the returning variable like that, otherwise it'd be this:
_new_permissions = []
for permission in args.permissions:
for perm in permission:
_new_permissions.append(perm)
args.permissions = _new_permissions
and repeated three times (pygame+sdl2+webview).
Member
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usage results:
single value
two or more values
two or more
--permissionargs with at least one value eachwhich is later flattened.
Closes #673