Add recipe to install ffpyplayer with many video formats support for old toolchain#952
Add recipe to install ffpyplayer with many video formats support for old toolchain#952germn wants to merge 2 commits intokivy:old_toolchainfrom
Conversation
…yer with all video formats support.
germn
changed the title
|
Thanks @germn , just to be clear I am not an approval authority for Kivy; but I do appreciate this PR and your work; it was something I was going to have to fix/address in a few weeks. Now solved. |
|
Thanks for the PR! @FeralBytes did you test this and it works? If so I'll happily merge it, but I no longer have the old toolchain set up for testing myself. |
|
@inclement I will test it and get back to you soon. I should be able to test it tonight. |
|
Just to be clear, this PR is for old toolchain (pygame based), but there's also one for new toolchain (SDL2 based): #954 I guess most users more interested in second one. |
|
@germn Sorry for the delay, I have very slow Internet and depend on a cell phone for my Internet. So downloading the Android SDK & NDK took some time. I am still going to test this and yes i realize it is for the pygame tool chain. |
|
@germn Now that I have everything in place; to run this and specifically test it; I just add "ffpyplayer_codecs" to the requirements in buildozer.spec correct? Or will it just work with an old toolchain build? |
|
@FeralBytes to enable more video formats support your just need to add also "ffpyplayer_codecs" to buildozer, for example:
|
|
I am sorry I did not mean to press comment. |
|
Removed Error Logs Polluting PR. |
|
@FeralBytes can you provide file you tested with? It would be cool also to see some example project to reproduce error. |
Sorry, I didn't mention it clearly, but it makes sense to test with kivy==master and latest commit in this PR. In this case versions should be Just to be clear: did code/file you tested work before this PR? |
|
@germn give me some more time; then and I will validate everything. |
|
Removed Error Logs Polluting PR. |
|
@germn I just confirmed with another Ubuntu 16.04 user that the old tool chain is also broken for him @Bakterija ... I use LM 18 but it pulls as a base from Ubuntu 16.04. |
|
@germn What is your OS and version? |
|
@FeralBytes I'm using Ubuntu 16.04 LTS inside Virtual box. Just to be clear: am I understanding correctly, that kivy==master with old toolchain (and without ffpyplayer at all) is broken for you right now? |
|
@germn Yes. |
|
@germn looks like you will need someone else to test until I get Kivy sorted out. I am currently just trying to get any Kivy APK to work; with no success for any of the methods or build chains. I am even using VM's. |
|
Since old toolchain is outdated I'll close this PR. |
3 participants
Current
ffpyplayerrecipe supports onlyh264+aac(only.mp4file format).This is confusing (since rarely mentioned anywhere) and probably doesn't meet people expectations (if I'm going to use video, probably I want to support more formats then only
.mp4). Here's some discussions/questions about it: 1, 2, 3, 4, 5.With this PR your can specify
ffpyplayer_codecs(additionally toffpyplayer) to enable all default codecs andlibx264,libshinealso. I tested it on couple of videos and couldn't find any that couldn't be processed.I'm new with bash and p4a, so I would ask you to check PR before merging. Thanks.