Skip to content

Add remove_presplash#930

Merged
inclement merged 2 commits intokivy:masterfrom
KeyWeeUsr:remove_presplash
Nov 26, 2016
Merged

Add remove_presplash#930
inclement merged 2 commits intokivy:masterfrom
KeyWeeUsr:remove_presplash

Conversation

@KeyWeeUsr
Copy link
Contributor

Remove SDL2 presplash function in android package.

ref #928

@inclement
Copy link
Member

I wonder if it would be preferable to just put this in an if BOOTSTRAP == 'sdl2' block rather than using the catchall try/except - this would be more in line with how the android module is currently structured, and I think fits fine with its somewhat ad-hoc support for things.

@KeyWeeUsr
Copy link
Contributor Author

So it's just a casual Python? It really doesn't seem like that, C macro rather and even that probably not. I can't find the config.pxi where I should probably look for the thing.

I mean, I can check for 'sdl2' but if I don't know if it really returns such thing with SDL2 on android, the code most likely won't be executed. Maybe it's just copied from the old code e.g. no 'sdl2' will be returned, because there was pygame only. Or I'm just confused, hmmm...

@inclement
Copy link
Member

I actually just guessed that 'sdl2' would work, you're right that we should understand it first.

@inclement
Copy link
Member

Looks like the config files are all written by the android recipe, and BOOTSTRAP is indeed just the bootstrap name, so checking for 'sdl2' should be fine.

@inclement inclement merged commit 9c30fd7 into kivy:master Nov 26, 2016
@inclement
Copy link
Member

👍

@KeyWeeUsr KeyWeeUsr deleted the remove_presplash branch December 17, 2016 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants