Skip to content

fix layout listener related issues. Closes #890 #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akshayaurora merged 1 commit into from
Oct 27, 2016
Merged

fix layout listener related issues. Closes #890 #911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 11 additions & 24 deletions pythonforandroid/recipes/android/src/android/_android.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,31 +179,18 @@ python_act = autoclass(JAVA_NAMESPACE + '.PythonActivity')
Rect = autoclass('android.graphics.Rect')
mActivity = python_act.mActivity
if mActivity:
class LayoutListener(PythonJavaClass):
__javainterfaces__ = ['android/view/ViewTreeObserver$OnGlobalLayoutListener']

height = 0

@java_method('()V')
def onGlobalLayout(self):
rctx = Rect()
# print('rctx_bottom: {0}, top: {1}'.format(rctx.bottom, rctx.top))
mActivity.getWindow().getDecorView().getWindowVisibleDisplayFrame(rctx)
# print('rctx_bottom: {0}, top: {1}'.format(rctx.bottom, rctx.top))
# print('activity height: {0}'.format(mActivity.getWindowManager().getDefaultDisplay().getHeight()))
# NOTE top should always be zero
rctx.top = 0
self.height = mActivity.getWindowManager().getDefaultDisplay().getHeight() - (rctx.bottom - rctx.top)
# print('final height: {0}'.format(self.height))

ll = LayoutListener()
IF BOOTSTRAP == 'sdl2':
python_act.getLayout().getViewTreeObserver().addOnGlobalLayoutListener(ll)
ELSE:
python_act.mView.getViewTreeObserver().addOnGlobalLayoutListener(ll)

# PyGame backend already has the listener so adding
# one here leads to a crash/too much cpu usage.
# SDL2 now does noe need the listener so there is
# no point adding a processor intensive layout listenere here.
height = 0
def get_keyboard_height():
return ll.height
rctx = Rect()
mActivity.getWindow().getDecorView().getWindowVisibleDisplayFrame(rctx)
# NOTE top should always be zero
rctx.top = 0
height = mActivity.getWindowManager().getDefaultDisplay().getHeight() - (rctx.bottom - rctx.top)
return height
else:
def get_keyboard_height():
return 0
Expand Down