Allow installation on Windows#902
Merged
inclement merged 1 commit intokivy:masterfrom Nov 1, 2016
emmatyping:master
Merged
Conversation
Member
|
Thanks for the PR, I guess it's harmless to include it even though p4a doesn't run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this does not allow one to use the full Python for Android toolchain. It simply removes the requirement for the sh module on Windows so that it is pip installable.
This addresses #819. I am not sure if a warning about the limited abilities is required, but this does allow one to pip install or use setup.py install. When I run p4a (for the curious), I get:
Something that I could modify for this PR is to change
check_python_dependenciesto not error on Windows, and instead add a message to wait for binary redistributable recipes.