Skip to content

Allow installation on Windows#902

Merged
inclement merged 1 commit intokivy:masterfrom
emmatyping:master
Nov 1, 2016
Merged

Allow installation on Windows#902
inclement merged 1 commit intokivy:masterfrom
emmatyping:master

Conversation

@emmatyping
Copy link
Contributor

@emmatyping emmatyping commented Oct 10, 2016

Note: this does not allow one to use the full Python for Android toolchain. It simply removes the requirement for the sh module on Windows so that it is pip installable.

This addresses #819. I am not sure if a warning about the limited abilities is required, but this does allow one to pip install or use setup.py install. When I run p4a (for the curious), I get:

C:\Users\ethanhs>p4a
ERROR: The sh Python module could not be found, please install version 1.10 or higher
python-for-android is exiting due to the errors above.

Something that I could modify for this PR is to change check_python_dependencies to not error on Windows, and instead add a message to wait for binary redistributable recipes.

@inclement
Copy link
Member

Thanks for the PR, I guess it's harmless to include it even though p4a doesn't run.

@inclement inclement merged commit 7bee654 into kivy:master Nov 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants