Port launcher to SDL2 bootstrap#891
Merged
inclement merged 12 commits intokivy:masterfrom Jan 15, 2017
Merged
Conversation
Fak3
reviewed
Oct 4, 2016
| } | ||
|
|
||
| /** | ||
| * Scans directory for a project.txt file. If it finds one, |
Contributor
There was a problem hiding this comment.
It should probably say android.txt
Contributor
Author
There was a problem hiding this comment.
Thanks, I only copied it from pygame bootstrap so it's even there. I'll fix it later ^^
Contributor
Author
Logcat, if anybody is interested. The java activity copied from pygame crashes, so this will probably take a while for me. I hope it's only path issue. But anyway, the build is fixed, the all necessary files should be already there and I don't see other annoying to fix stuff. 🍡 so... yeah Java. |
Contributor
Author
|
I'll do little changes and it's ready ^^ |
Contributor
Author
Member
|
Looks good at a quick check, nice work! The launcher testapps are a particularly nice touch :) I'll test it properly sometime in the next few days. |
Contributor
Author
|
I've tested it and it should be ready, but there are some things that worry me:
I'd appreciate any pointings on what is where broken or how to get the python header into the tar. How to test: |
KeyWeeUsr
force-pushed
the
sdl2_launcher
branch
from
fa5dd4c to
6ef65cf
Compare
KeyWeeUsr
force-pushed
the
sdl2_launcher
branch
from
6ef65cf to
7bee654
Compare
Contributor
Author
|
Py3 attempt still fails due to collision: The missing pngs had only a slightest difference between logs when ran as casual app and via launcher: both cases had loaded this in the beginning, so I'm really curious what's going on: |
Contributor
Author
|
Scratch that Also the black in the presplash was bad, I could see the presplash image popping out from darkness even with a screen filter, so I cut the rocket out and put into the casual app's presplash. It's even more consistent now 😋 So... the launcher is finally back and kicking 🍡
|
This was referenced Nov 12, 2016
KeyWeeUsr
force-pushed
the
sdl2_launcher
branch
from
128df7b to
91b4fde
Compare
Contributor
Author
|
I kind of forgot to include the change about orientation, now it's here. Also, there's this thing that If we run with
and other stuff. Loading of libraries such as here should target only variables that if changed will break everything and won't allow python program to run, such as Anything else non-related to launcher should work just fine. |
If only Project*.java is used, it discards even Project.java, which results in 'not found' in PythonActivity.java and stops compilation. Same thing will happen if you try to separate it to a package (org.kivy.launcher), but with more pain while trying to fix it.
basically creating .kivy folder(logs), fetching files with paths relative to main.py and so on. ANDROID_APP_PATH has to be the folder of main.py file.
KeyWeeUsr
force-pushed
the
sdl2_launcher
branch
from
98ce8bd to
2004698
Compare
Member
|
Looks good, thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says, I'm attempting to port pygame launcher to the sdl2 bootstrap. The copied files + some lines in pygame's
PythonActivity.javawere probably the only thing that made the launcher work. I'm not sure though and I'm not really experienced in java, so I welcome any help. ^^