alternative version string to download from sourceforge;#575
Merged
inclement merged 2 commits intokivy:masterfrom Jan 13, 2016
Merged
alternative version string to download from sourceforge;#575inclement merged 2 commits intokivy:masterfrom
inclement merged 2 commits intokivy:masterfrom
Conversation
Member
|
@tito Do you think this fix is okay, or is there a reason that your original version was necessary? |
Contributor
Author
|
Apparently sourceforge is serving a different page (js/html support) depending on the headers of the client that is compatible with the standards urllib is following. (Additionally I advice renaming the class Chrome... to Wget...) |
Member
|
Nobody's piped up, so let's assume no problems, it's an easy fix if something goes wrong. Thanks again! |
inclement
added a commit
that referenced
this pull request
Jan 13, 2016
alternative version string to download from sourceforge;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also fixes #573 but simpler solution