Skip to content

Distribute.sh doesnt work properly with python3#56

Merged
tito merged 2 commits intokivy:masterfrom
bgola:master
Dec 8, 2012
Merged

Distribute.sh doesnt work properly with python3#56
tito merged 2 commits intokivy:masterfrom
bgola:master

Conversation

@bgola
Copy link
Copy Markdown
Contributor

@bgola bgola commented Oct 16, 2012

As the title says, if the 'python' executable points to python3 then distribute.sh will not work properly. This pull request will work for python >= 2.6

@bgola bgola closed this Oct 16, 2012
@tshirtman
Copy link
Copy Markdown
Member

Not sure why you closed the request, if it works for all python >= 2.6, it's a nice imporvement :)

@bgola
Copy link
Copy Markdown
Contributor Author

bgola commented Oct 16, 2012

i decided to test it a little bit more before reopening.

but i don't know why i'm having some problems to create a distribution (kivy/cython stuff), it's not related to my changes but I can't test if the whole process will really work with python3.

anyway reopening it... maybe someone can test and confirm it's working.

@bgola bgola reopened this Oct 16, 2012
@tito
Copy link
Copy Markdown
Member

tito commented Oct 16, 2012

Actually, i think if you have python3 as default, some things will not work: we are compiling an hostpython 2.7, so we must use it everywhere. BUT, in some case, like cython, it will generate code that doesn't work on 2.7 (it happened to me one time :/).

@tito tito merged commit 0dc80e8 into kivy:master Dec 8, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants