Conversation
|
SDL does not builds with ndk CC: @misl6 |
|
Will continue working on the SDL3 recipes this weekend, however we are going to support both SDL2 and SDL3 for a long time, as only Kivy 3.0.0 will support SDL3, and will not be ready quite soon. Maybe we can use NDK 27 only for some specific recipes? (or a previous one for SDL2) |
|
Just saw fixed was also pushed for SDL2, so bumped version to include that fix. :) |
5e09b20 to
48a215a
Compare
df40a87 to
b972e5a
Compare
AndreMiras
left a comment
There was a problem hiding this comment.
Impressive work so far!
Thanks for picking this up too @T-Dynamos 🙏
Maybe it's a good time to rebase it since SDL3 (#3125) was merged
|
Should I document this things or add warnings in code: |
a8d8c9b to
bce0f13
Compare
Yeah maybe failing early with an explicit message would do it, what do you think? |
03f4727 to
ad494ed
Compare
ad494ed to
c199e4f
Compare
|
This PR is ready for review. CI fails due to out of storage? I was able to build it on my computer with only single arch, Anyways it's only made to build on linux computer with 64bit android arches. |
|
Ping @AndreMiras ! What to do with the failing tests? Just ignore them and merge? I have personally tested this PR. |
Thanks for giving it a try and thank you T-Dynamos for the huge effort getting that one to work 🥇 |
c199e4f to
09d5196
Compare
09d5196 to
af20c5f
Compare
Closes #3116
Cons:
Extra Notes:
Removes need to use
LEGACY_NDKas it uses fortran from https://github.com/termux/ndk-toolchain-clang-with-flang.