Skip to content

add service_lib and aar to the docs#2634

Merged
misl6 merged 5 commits intokivy:developfrom
mzakharo:service_library_aar_docs
Jul 14, 2022
Merged

add service_lib and aar to the docs#2634
misl6 merged 5 commits intokivy:developfrom
mzakharo:service_library_aar_docs

Conversation

@mzakharo
Copy link
Contributor

  • Adding service_library and 'aar' generation to the documentation.
  • Removing absolute paths from service file declaration.
  • Adding mention of foreground and sticky options in services.

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions and a question.

Thank you for taking care about service_lib docs!

(And thank you for re-using a pygame-era paragraph 😂 which was still in the docs)

mzakharo and others added 3 commits July 13, 2022 16:53
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
@mzakharo mzakharo requested a review from misl6 July 14, 2022 19:14
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion on a minor typo, but looks good!

Co-authored-by: Mirko Galimberti <me@mirkogalimberti.com>
@mzakharo mzakharo requested a review from misl6 July 14, 2022 20:17
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6 misl6 merged commit cae8a85 into kivy:develop Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants