Skip to content

Bumps libffi to v3.4.2 + adds -fPIC on i686-linux-android#2578

Merged
misl6 merged 1 commit intokivy:developfrom
misl6:fix/libffi-x86-macos
Apr 16, 2022
Merged

Bumps libffi to v3.4.2 + adds -fPIC on i686-linux-android#2578
misl6 merged 1 commit intokivy:developfrom
misl6:fix/libffi-x86-macos

Conversation

@misl6
Copy link
Member

@misl6 misl6 commented Apr 14, 2022

  • Bumps libffi from v3.3 to v3.4.2 ( v3.3 was failing to build via Android-LLVM on macOS as -flto flag is present in CFLAGS by default (See: libffi/pull/590)
  • Added missing -fPIC to Archx86 (i686-linux-android)

⚠️ Do not merge it yet as it needs some tests during runtime.
✅ Tests passed during runtime on on_device_unit_tests (On a arm64-v8a device)

@misl6 misl6 requested a review from AndreMiras April 15, 2022 19:02
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@misl6 misl6 merged commit 0e87b99 into kivy:develop Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants