Fixed kivy recipe to work on repeated runs with P4A_kivy_DIR#251
Merged
tito merged 1 commit intokivy:masterfrom May 16, 2015
inclement:so_fix
Merged
Fixed kivy recipe to work on repeated runs with P4A_kivy_DIR#251tito merged 1 commit intokivy:masterfrom inclement:so_fix
tito merged 1 commit intokivy:masterfrom
inclement:so_fix
Conversation
Member
|
Ok, then, let's go. At least, it will resolve current issue that people don't clean their own kivy between 2 different arch build. |
tito
added a commit
that referenced
this pull request
May 16, 2015
Fixed kivy recipe to work on repeated runs with P4A_kivy_DIR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not for merging without discussion!
This would fix #234
I'm not sure if this is the right fix, but I'm doing a pr in the hope that someone who knows what's going on will see it. As far as I can tell, it does resolve the linked issue.
Without this pr, something doesn't work - the build_ext lines don't place object files where the biglink script can see them. I think the issue is that they recognise the pyx source files haven't changed and therefore don't rebuild the object files, whereas with this fix cython is always called and the files are always rebuilt.
As discussed with tito, maybe there is a better solution, but I'm not even completely sure what's going on and I couldn't track it down better than this.