Merged
Conversation
AndreMiras
approved these changes
Aug 19, 2020
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM, nothing against it as long as it doesn't break default setup
| targetSdkVersion {{ android_api }} | ||
| versionCode {{ args.numeric_version }} | ||
| versionName '{{ args.version }}' | ||
| manifestPlaceholders = {{ args.manifest_placeholders}} |
Member
There was a problem hiding this comment.
I didn't get a chance to check, but I assume this default behaviour you introduced doesn't break anything right?
Could you try to run the auto-compiled test apps on device and confirm it's not breaking?
Member
Author
There was a problem hiding this comment.
It just adds an empty map, so it shouldn't break anything.
BTW, I just downloaded the artifact for arm64-v8a and it works flawlessly.
Member
There was a problem hiding this comment.
Nice thanks for giving a try, let's merge 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the
manifestPlaceholdersusage as described here: https://developer.android.com/studio/build/manifest-build-variables