download_file: show error + exponential sleep#2291
Merged
AndreMiras merged 2 commits intokivy:developfrom Aug 11, 2020
Merged
Conversation
AndreMiras
approved these changes
Aug 11, 2020
Member
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM thanks
Funnily this recent build didn't fail #2292
Member
|
Also I think this build error was fixed by your recent PR #2292 let's merge |
Contributor
Author
Yeah. The download failure seems to have disappeared on its own (for now). And the new problem was fixed by that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to fix the travis osx build, but the download failure seems to have been replaced by a different problem :(
Might still be a useful modification though.