Merged
Conversation
AndreMiras
approved these changes
Jun 25, 2020
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Thanks for the PR!
While I'm happy we're doing a bump anyway, I don't think the version necessarily has to follow the one of a popular distribution. Ideally it should simply compile fine in any and eventually we should also compile any host dependencies needed to achieve it
vesellov
pushed a commit
to vesellov/python-for-android
that referenced
this pull request
Feb 10, 2021
* bump libpq version * Fix libpq env for cross compile Co-authored-by: Rene Leveille <rene@nestingsafe.com>
germn
pushed a commit
to germn/python-for-android
that referenced
this pull request
Mar 20, 2021
* bump libpq version * Fix libpq env for cross compile Co-authored-by: Rene Leveille <rene@nestingsafe.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since buildozer bumped ubuntu versions for their docker image to ubuntu 20.04, the version in the recipe of libpq does not follow the one privided by that distro.
Bumping the version of libpq to follow the one provided by ubuntu 20.04, which is postgresql 10.12, is the easiest way to be able to compile this library on that docker image.
The addition of the environment variable
USE_DEV_URANDOMprevents the./configurestage to look for the file/dev/urandomwhile cross compiling.