Updated gradle plugin version#2234
Merged
AndreMiras merged 1 commit intokivy:developfrom Dec 28, 2020
shashi278:patch-1
Merged
Conversation
Got rid of deprecated compile method
AndreMiras
approved these changes
Dec 28, 2020
Member
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
CI happy so we should be fine, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
compilemethod. Replaced them withimplementation.* Added extra(Because Google services plugin requires a google-services.json file so this plugin must only be added if requires)classpathandapply pluginas they're required to use firebase(Instead of hardcoding these in the build.gradle file, there could be options to add extraclasspathandapply pluginas per one's requirement).