Skip to content

📦 Split logic for build modes & debug symbols#2213

Merged
opacam merged 1 commit intokivy:developfrom
opacam:hotfix-build-mode-and-debug-symbols
May 25, 2020
Merged

📦 Split logic for build modes & debug symbols#2213
opacam merged 1 commit intokivy:developfrom
opacam:hotfix-build-mode-and-debug-symbols

Conversation

@opacam
Copy link
Member

@opacam opacam commented May 22, 2020

If we want to keep debug symbols from .so files we will use: --with-debug-symbols

Also:

  • enable debug builds for all bootstraps (AndroidManifest.tmpl.xml)
  • add log message to make it clear what kind of build we will get

This closes #2207

If we want to **keep** debug symbols from `.so` files we will use:
  `--with-debug-symbols`

Also:
  - enable debug builds for all bootstraps (AndroidManifest.tmpl.xml)
  - add log message to make it clear what kind of build we will get
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice follow up, I think that matches what @inclement were pointing. Good job 👏

if ctx.with_debug_symbols
else '',
)
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet

Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@opacam opacam merged commit 0610d20 into kivy:develop May 25, 2020
@opacam opacam deleted the hotfix-build-mode-and-debug-symbols branch May 25, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apk size growing

3 participants