Conversation
opacam
force-pushed
the
feature-opencv-extras
branch
from
9f0aa3b to
eb6cc6b
Compare
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
Well done, looking good 👏
Ping me once it's no longer WIP so I don't miss it
Makefile
Outdated
| . $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \ | ||
| python setup.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \ | ||
| --requirements libffi,sdl2,pyjnius,kivy,python3,openssl,requests,sqlite3,setuptools,numpy \ | ||
| --requirements libffi,sdl2,pyjnius,kivy,python3,openssl,requests,sqlite3,setuptools,numpy,opencv,opencv_extras \ |
There was a problem hiding this comment.
Do we really want to have opencv and extras build each time? Or is it just for temporary testing the PR?
There was a problem hiding this comment.
hahaha....this was only to test the build...I will reverse it later (that is why I labeled this PR wip and put the emoji 🚧 in my last commit).
Here are the artifacts for each arch:
https://github.com/kivy/python-for-android/actions/runs/110275077
Btw, it almost doubles the size of the apk...anyway, it may be useful to someone and it doesn't look like hard to maintain.
There was a problem hiding this comment.
Great that what's I thought, but wasn't sure 👍
I have nothing against merging, ping me for the final review
This reverts commit eb6cc6b
|
Thanks and well done Opacam. I will keep you up to date on my progress with using this recipe. |
AndreMiras
left a comment
AndreMiras
left a comment
There was a problem hiding this comment.
LGTM, is this still in progress?
| 'libopencv_dnn.so', | ||
| 'libopencv_imgcodecs.so', | ||
| 'libopencv_photo.so' | ||
| # todo: add opencv_extras libraries |
There was a problem hiding this comment.
what's the story on that one?
|
Well, the travis error is expected...this recipes compiles an insane number of libraries and it takes too long, anyway, we know that it builds thanks to previous tests with gh-actions, so let's merge this!! @AndreMiras, thanks for the review!! 😄 @SonofPoseidon1982, thanks for the testing and feedback!! 👍 |
3 participants
This recipe allows us to build extra modules from the
opencv_contribrepository. It depends onopencvrecipe and all the build of the modules will be performed inside opencv build directory.This closes #2206
Note: I've not tested this recipe at runtime but it builds fine for
arm64-v8ain my local tests, plus generates the extra opencv libraries (which are a lot so probably will increase the size of the apk considerably).See also: https://github.com/opencv/opencv_contrib