Add possibility to add a backup rules xml file#2208
Conversation
|
This would be very nice to have, thanks! |
|
It is expected, since I duplicated behavior from an existing command line argument. I copied the help text, advising that the path needs to be relative to I have too little insight into the inner workings of p4a to implement a better way, but I'm happy to update this PR if someone tells me how to make this relative to the project root or similar. |
|
I do think it would be better to make it relative to either the current working directory ( |
|
I have a PR ready to be submitted for adding support for |
Also enables the "allowBackup" flag for webview and service_only bootstraps, where the AndroidManifest.tmpl.xml would set it to a hardcoded "true".
Instead of relative to p4a, use path relative to the private directory.
|
I went for Sorry Edit: |
|
I'm not an expert by any means, but maybe it would be easier to just close this PR and open another "clean" one? |
|
nothing wrong with force pushing if you rebased/reset the branch to clean up, the PR will update itself if you push to the same branch. the way i would go about it: this will open vim, or whatever EDITOR you have configured. then press Then the rebasing will start, hopefuly it'll complete without issues, if you get conflicts, it's going to be a bit more painful, so let's hit that wall when we get there, if all goes well, just use |
d5ee322 to
db7168f
Compare
|
thanks @tshirtman that seems to have done the trick then :) Let me know if there are further changes to be included, before this can be merged |
* Add possibility to add a backup rules xml file Also enables the "allowBackup" flag for webview and service_only bootstraps, where the AndroidManifest.tmpl.xml would set it to a hardcoded "true". Use path relative to the private directory.
* Add possibility to add a backup rules xml file Also enables the "allowBackup" flag for webview and service_only bootstraps, where the AndroidManifest.tmpl.xml would set it to a hardcoded "true". Use path relative to the private directory.
This PR enables users to pass a new argument to p4a to enable
custom backup rules through the means of an XML file as documented
in the official Android docs.
I also noticed that the "allowBackup" flag would do nothing when userd
with either
webvieworservice_onlybootstraps, where theAndroidManifest.tmpl.xmlwould set it to a hardcoded "true" instead ofthe user-defined value.