✅ Add initial tests for python3 recipe#2192
Merged
opacam merged 1 commit intokivy:developfrom May 12, 2020
Merged
Conversation
This covers an 84% of the python recipe. Most of the uncovered code is related with `set_lib_flags` (marked with a `todo` inline comment)
opacam
force-pushed
the
feature-python3-initial-tests
branch
from
ea51363 to
09c22bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This covers an 84% of the python recipe.
Most of the uncovered code is related with
set_lib_flags(marked with atodoinline comment).I think that is better to deal with it later, since it may require to touch python3's recipe (again)...also it crossed to my mind that maybe we should reduce a little the complexity of that part...I'm still not sure...